On 2015/03/11 22:04:53, indutny wrote:
Yang,
Updated the CL. Please note that I have changed DCHECK in handles-inl.h to
CHECK, to make sure that it fails in both debug and release modes.
Thank you!
Please do not do that. That would directly affect all embedders of V8
regarding
performance. Creating handles can be performance critical in a few places.
Why don't you set the limit of the current handle block, like in the
internal
implementation of SealHandleScope? The idea there is that when we attempt to
Extend, we run into the level check there. Since we have to do the limit
check
either way, this won't make creating a handle more expensive. You can
remove the
CHECK in CreateHandle.
https://codereview.chromium.org/985873002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
