LGTM with comments.
https://codereview.chromium.org/985873002/diff/40001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/985873002/diff/40001/src/api.cc#newcode701
src/api.cc:701: "Entering the V8 API without proper locking in place");
Do we actually need this check here? If you want to create a handle,
what you need is a HandleScope, which would check for locking. By having
a SealHandleScope, we would explicitly require a new HandleScope if
someone wants to create a handle.
https://codereview.chromium.org/985873002/diff/40001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/985873002/diff/40001/test/cctest/test-api.cc#newcode21661
test/cctest/test-api.cc:21661: CHECK(!obj.IsEmpty());
You can use USE(obj);
https://codereview.chromium.org/985873002/diff/40001/test/cctest/test-api.cc#newcode21679
test/cctest/test-api.cc:21679: CHECK(!obj.IsEmpty());
Same here.
https://codereview.chromium.org/985873002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
