On 2015/03/13 14:54:47, kozyatinskiy wrote:
Yang, please take a look.
https://codereview.chromium.org/919653002/diff/160001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/919653002/diff/160001/src/objects.cc#newcode10334
src/objects.cc:10334: String* debug_name = NULL;
On 2015/03/13 14:18:21, yurys wrote:
> You should avoid raw pointers in methods that may cause GC. In this
case it
> should be Handle<String> or event better you can avoid this local
variable
> altogether:
>
> if (name->IsString())
> return Handle<String>::cast(name);
Done.
lgtm.
https://codereview.chromium.org/919653002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
