On 2015/03/17 09:16:02, dcarney wrote:
On 2015/03/17 09:14:05, dcarney wrote:
> lgtm
it would be preferred to pass the isolate in the messagecallback, would
that
be
okay? if so, i'll prepare a cl to change the callback instead
It would work either way, I don't have strong opinion on that. I'd rather
incorporate error object passed as a separate parameter to MessageCallback
into
Message object and have MessageCallback accept single parameter. What's the
advantage of passing Isolate as a separate parameter?
https://codereview.chromium.org/1015643002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
