On 2015/03/17 10:31:01, dcarney wrote:
On 2015/03/17 10:30:12, yurys wrote:
> On 2015/03/17 10:25:25, dcarney wrote:
> > > It would work either way, I don't have strong opinion on that. I'd
rather
> > > incorporate error object passed as a separate parameter to
MessageCallback
> > into
> > > Message object and have MessageCallback accept single parameter.
What's
the
> > > advantage of passing Isolate as a separate parameter?
> >
> > it's more consistent with the rest of the api. we try to pass
isolate as
the
> > first parameter. sometimes it's not worth the trouble to change the
api.
> since
> > i don't know how these callbacks are used in blink, i don't know how
> complicated
> > it would be
>
> It should be fairly simple. The callbacks are added in
V8Initializer.cpp,
one
> for worker isolate, another for main thread.
okay, i'll just convert them for consistency
Thanks. I'm closing this issue then.
https://codereview.chromium.org/1015643002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
