On Tue, Mar 17, 2015 at 12:27 PM,  <[email protected]> wrote:
> Hi Ben
>
> A few things I noticed about the CPU improvement change in Node 0.10.36:
> * It does not appear to have been contributed upstream to V8

That's because the 3.14 branch is dead and unsupported by the V8 team.

> * It only changes POSIX platforms (Windows still uses Sleep(0) a.k.a. yield)

Laziness on my part.  None of our customers care about Windows and I
didn't have much inclination to set up Visual Studio again.

> * It hasn't been fully carried forward to 0.12 (I plan to raise a pull
> request to address this, based on
> https://github.com/tunniclm/node/commit/b2c2902f217a7dbae15d4a82d27d984c982415e2),
> that is, the change to YieldCPU() on POSIX was carried forward, but it is no
> longer called in ProfilerEventsProcessor::Run() due to V8 changes

We don't carry the patch in io.js because it's not necessary with V8
4.1.  I can't comment on the V8 3.28 that ships with node.js v0.12,
it's been too long since I last looked at it.

-- 
-- 
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- 
You received this message because you are subscribed to the Google Groups 
"v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to