Hi Ben > A few things I noticed about the CPU improvement change in Node 0.10.36: > > * It does not appear to have been contributed upstream to V8 > > That's because the 3.14 branch is dead and unsupported by the V8 team. >
Right, but I thought this was a problem on the latest V8 release as well, maybe I am mistaken though. I tested on the master branch of https://github.com/v8/v8-git-mirror a little while back. > * It hasn't been fully carried forward to 0.12 (I plan to raise a pull > > request to address this, based on > > > https://github.com/tunniclm/node/commit/b2c2902f217a7dbae15d4a82d27d984c982415e2), > > > > that is, the change to YieldCPU() on POSIX was carried forward, but it > is no > > longer called in ProfilerEventsProcessor::Run() due to V8 changes > > We don't carry the patch in io.js because it's not necessary with V8 > 4.1. I can't comment on the V8 3.28 that ships with node.js v0.12, > it's been too long since I last looked at it. > OK, I looked at V8 4.1.0.22 and some later versions and I cpu-profiler.cc still looks like it's doing a busy loop. Is there a specific version I can test to see the problem resolved? Thanks Michael -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
