Looking good, just nits.
https://codereview.chromium.org/1010673004/diff/60001/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):
https://codereview.chromium.org/1010673004/diff/60001/src/compiler/pipeline.cc#newcode319
src/compiler/pipeline.cc:319: bool CreateGraph(bool constant_context) {
nit: Can we add a "bool stack_check" to the CreateGraph method here and
move the "info->IsStub()" to the call-site? That would make it less
hidden away.
https://codereview.chromium.org/1010673004/diff/60001/src/compiler/pipeline.cc#newcode336
src/compiler/pipeline.cc:336: bool stack_check_;
nit: This field is not required once the above comment is addressed.
https://codereview.chromium.org/1010673004/diff/60001/src/runtime.js
File src/runtime.js (right):
https://codereview.chromium.org/1010673004/diff/60001/src/runtime.js#newcode698
src/runtime.js:698:
nit: Can we put in a separator comment here like the following? This
would make it clear what these functions are intended for.
/* -----------------------------------------------
- - - J a v a S c r i p t S t u b s - - -
-----------------------------------------------
*/
https://codereview.chromium.org/1010673004/diff/60001/src/runtime.js#newcode699
src/runtime.js:699: function StringLengthStub(name) {
nit: Also maybe make this one function all-uppercase, so that the
comment in lines 7 to 9 applies.
https://codereview.chromium.org/1010673004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
