https://codereview.chromium.org/1010673004/diff/80001/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/1010673004/diff/80001/src/compiler.cc#newcode224
src/compiler.cc:224: return scope() == nullptr ? parameter_count_ :
scope()->num_parameters();
Maybe we should have a has_scope() predicate?
https://codereview.chromium.org/1010673004/diff/80001/src/compiler/js-intrinsic-lowering.cc
File src/compiler/js-intrinsic-lowering.cc (right):
https://codereview.chromium.org/1010673004/diff/80001/src/compiler/js-intrinsic-lowering.cc#newcode118
src/compiler/js-intrinsic-lowering.cc:118:
NodeProperties::ReplaceWithValue(node, result);
This looks like a good candidate to mutate in place. You should be able
to just do:
NodeProperties::ReplaceWithValue(node, node)
https://codereview.chromium.org/1010673004/diff/80001/src/compiler/js-intrinsic-lowering.cc#newcode205
src/compiler/js-intrinsic-lowering.cc:205:
NodeProperties::ReplaceWithValue(node, result);
Same as above.
https://codereview.chromium.org/1010673004/diff/80001/src/hydrogen.h
File src/hydrogen.h (right):
https://codereview.chromium.org/1010673004/diff/80001/src/hydrogen.h#newcode2237
src/hydrogen.h:2237: /* JSValue */ \
We need a better name for this operation.
https://codereview.chromium.org/1010673004/diff/80001/src/runtime/runtime.h
File src/runtime/runtime.h (right):
https://codereview.chromium.org/1010673004/diff/80001/src/runtime/runtime.h#newcode720
src/runtime/runtime.h:720: F(JSValueValue, 1, 1)
We need a better name somehow...
BTW what are the checks associated with this JSValueValue? What happens
if you pass a SMI?
https://codereview.chromium.org/1010673004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
