https://codereview.chromium.org/1013143003/diff/30001/src/profile-generator.cc
File src/profile-generator.cc (right):
https://codereview.chromium.org/1013143003/diff/30001/src/profile-generator.cc#newcode123
src/profile-generator.cc:123: info.AddInlineFrame(script_id_, position_
+ deopt_position_.position());
Looks strange. Why do you want to add an inline frame if there's no
inlined_functions_info?
https://codereview.chromium.org/1013143003/diff/30001/src/profile-generator.cc#newcode226
src/profile-generator.cc:226: indent + 10, "", 4, "",
info.stack[i].script_id,
4, ""
why?
https://codereview.chromium.org/1013143003/diff/30001/src/profile-generator.h
File src/profile-generator.h (right):
https://codereview.chromium.org/1013143003/diff/30001/src/profile-generator.h#newcode40
src/profile-generator.h:40: struct DeoptInfo {
turn it into a class?
https://codereview.chromium.org/1013143003/diff/30001/src/profile-generator.h#newcode90
src/profile-generator.h:90: DeoptInfo GetDeoptInfo();
seems to be quite a big object to return by value
https://codereview.chromium.org/1013143003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
