lgtm
https://codereview.chromium.org/1013143003/diff/130001/src/compiler.h
File src/compiler.h (right):
https://codereview.chromium.org/1013143003/diff/130001/src/compiler.h#newcode100
src/compiler.h:100: std::vector<size_t> deopt_pc_offsets;
Why's the change? AFAICT v8 tends to use 32-bit types for storage
whenever possible to reduce memory footprint.
https://codereview.chromium.org/1013143003/diff/130001/src/compiler.h#newcode468
src/compiler.h:468: std::vector<InlinedFunctionInfo>*
inlined_function_infos_;
why not using a smart pointer?
https://codereview.chromium.org/1013143003/diff/130001/src/profile-generator.cc
File src/profile-generator.cc (right):
https://codereview.chromium.org/1013143003/diff/130001/src/profile-generator.cc#newcode232
src/profile-generator.cc:232: for (size_t i = 1; i < info->stack.size();
++i) {
could you please use a distinct variable for inner loop iterator.
https://codereview.chromium.org/1013143003/diff/130001/src/profile-generator.h
File src/profile-generator.h (right):
https://codereview.chromium.org/1013143003/diff/130001/src/profile-generator.h#newcode151
src/profile-generator.h:151: std::vector<InlinedFunctionInfo>*
inlined_function_infos_;
ditto
https://codereview.chromium.org/1013143003/diff/130001/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):
https://codereview.chromium.org/1013143003/diff/130001/test/cctest/test-cpu-profiler.cc#newcode1859
test/cctest/test-cpu-profiler.cc:1859: //
0.........1.........2.........3.........4.........5.........6.........7
nit: shifted a bit
https://codereview.chromium.org/1013143003/diff/130001/test/cctest/test-cpu-profiler.cc#newcode1927
test/cctest/test-cpu-profiler.cc:1927: //
0.........1.........2.........3.........4.........5.........6.........7
ditto
https://codereview.chromium.org/1013143003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
