Non-OWNER LGTM. Please add a test for the parenthesized version as well --
i.e.
(x)=>x+1 in addition to x=x+1.
Is it possible that this strange situation arises in eager parsing? Or in
eager
parsing would we always detect the Token::ILLEGAL and bail?
https://codereview.chromium.org/1023483003/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1023483003/diff/1/src/parser.cc#newcode1154
src/parser.cc:1154: DCHECK(expression->IsFunctionLiteral());
One thing I didn't get when first reading this code is that this DCHECK
must be true because the function was already pre-parsed, so we know
what to expect. Perhaps a one-line comment here?
https://codereview.chromium.org/1023483003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
