The patch only needs to cover the case of lazy parsing.
I have checked eager parsing with a similar test case using
“eval('v => v + 1')” in place of the arrow function. It works
fine in the current Git HEAD, without needing the fix.
https://codereview.chromium.org/1023483003/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1023483003/diff/1/src/parser.cc#newcode1154
src/parser.cc:1154: DCHECK(expression->IsFunctionLiteral());
On 2015/03/19 07:48:45, wingo wrote:
One thing I didn't get when first reading this code is that this
DCHECK must be
true because the function was already pre-parsed, so we know what to
expect.
Perhaps a one-line comment here?
Acknowledged.
https://codereview.chromium.org/1023483003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
