lgtm
https://codereview.chromium.org/1019813004/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/1019813004/diff/1/src/heap-snapshot-generator.cc#newcode3080
src/heap-snapshot-generator.cc:3080:
base::TimeDelta().InMilliseconds())>::kUnsigned // NOLINT
one is timedelta, another is id. these are two different types.
https://codereview.chromium.org/1019813004/diff/1/src/heap-snapshot-generator.cc#newcode3088
src/heap-snapshot-generator.cc:3088: if (first_entry) {
i != 0
https://codereview.chromium.org/1019813004/diff/1/src/heap-snapshot-generator.cc#newcode3094
src/heap-snapshot-generator.cc:3094: buffer_pos =
utoa(time_delta.InMilliseconds(), buffer, buffer_pos);
Let's use microseconds as we do in cpu profiler to be consistent. wdyt?
https://codereview.chromium.org/1019813004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
