On 2015/03/20 10:38:13, yurys wrote:
On 2015/03/20 10:24:59, Yang wrote:
> On 2015/03/20 08:30:41, yurys wrote:
> >
>
https://codereview.chromium.org/1019813004/diff/20001/src/heap-snapshot-generator.cc
> > File src/heap-snapshot-generator.cc (right):
> >
> >
>
https://codereview.chromium.org/1019813004/diff/20001/src/heap-snapshot-generator.cc#newcode2949
> > src/heap-snapshot-generator.cc:2949: JSON_S("timstamp_ms") ","
> > On 2015/03/19 20:43:53, alph wrote:
> > > _usec or just timestamp?
> >
> > Done.
>
> Can we have a test case or extend an existing one?
Historically all tests of the serialized snapshot live in Blink, on v8
side we
only have tests for heap data collection using v8-profiler.h
API(test-heap-profiler.cc). I'm going to add new tests for this
functionality
in
Blink.
lgtm.
https://codereview.chromium.org/1019813004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
