https://codereview.chromium.org/1023153002/diff/1/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/1023153002/diff/1/src/heap/gc-idle-time-handler.cc#newcode160
src/heap/gc-idle-time-handler.cc:160: last_mark_compact_time +
kMinMillisecondsInBetweenMarkCompact;
you're adding seconds + milliseconds here as far as I can tell
https://codereview.chromium.org/1023153002/diff/1/src/heap/gc-idle-time-handler.cc#newcode213
src/heap/gc-idle-time-handler.cc:213: printf("start idle round, contexts
disposed\n");
debug code?
https://codereview.chromium.org/1023153002/diff/1/src/heap/gc-idle-time-handler.h
File src/heap/gc-idle-time-handler.h (right):
https://codereview.chromium.org/1023153002/diff/1/src/heap/gc-idle-time-handler.h#newcode141
src/heap/gc-idle-time-handler.h:141: static const double
kMinMillisecondsInBetweenMarkCompact;
MinTime...InMs would be more consistent with the other constants
https://codereview.chromium.org/1023153002/diff/1/src/heap/gc-idle-time-handler.h#newcode194
src/heap/gc-idle-time-handler.h:194: double last_mark_comact_time,
idle_time_in_ms is a size_t value. Can last_mark_com*p*act_time be a
size_t as well? And what's the time unit?
https://codereview.chromium.org/1023153002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
