In terms of testability it's not great to add more time-based decision
making.
It would be good to get to a place where the test harness could call the
idle
API and there was no other time based decision making.
https://codereview.chromium.org/1023153002/diff/80001/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/1023153002/diff/80001/src/heap/gc-idle-time-handler.cc#newcode240
src/heap/gc-idle-time-handler.cc:240: if
(heap_state.incremental_marking_stopped) {
It feels like we are piling more and more heuristics on. Does anyone
understand the current system?
It looks like the bit above ("IsMarkCompactIdleRoundFinished") will run
7 GCs in the idle time, and then not start another until we have
allocated enough garbage or there has been a context disposal. That
would seem to be plenty of GCs. Why do we need more than that?
https://codereview.chromium.org/1023153002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
