https://codereview.chromium.org/1013143003/diff/190001/src/compiler.h
File src/compiler.h (right):
https://codereview.chromium.org/1013143003/diff/190001/src/compiler.h#newcode352
src/compiler.h:352: const std::vector<InlinedFunctionInfo>&
inlined_function_infos() {
Hmmm, returning this by reference is not nice: Looking at the use sites
of this function, I fail to see why it is even correct, i.e. why the
CompilationInfo is still alive at that point. Even if it *was* correct,
let's not do this, reasoning globally about tricky lifetimes is a recipe
for bugs later: Just return this by value, there should only be a tiny
handful of entries in it (AFAICT).
https://codereview.chromium.org/1013143003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
