Lets not reuse strong mode. Those might change for other reasons. On Tue, Mar 24, 2015 at 12:36 PM, <[email protected]> wrote: > On 2015/03/24 11:35:02, caitp wrote: >> >> On 2015/03/24 11:30:50, arv wrote: >> > It is not clear why we need 4 new maps? Can you list the different cases >> > of >> > functions and how their maps differ? > > >> SLOPPY_FUNCTION_MAP and SLOPPY_FUNCTION_WITHOUT_PROTOTYPE_MAP install >> caller/arguments accessors as own properties, which is forbidden. The >> strict >> variants of these install the poisoned accessors as own properties, which >> is >> also forbidden. For legacy syntactic forms, this behaviour is still needed >> --- >> so it seems that you need the extra maps. > > >> If the global maps weren't set up, and the accessors were added during > > function >> >> instantiation, you'd still end up with new maps implicitly. > > > It may be possible to just reuse the strong mode variants, but that may have > other implications > > > https://codereview.chromium.org/1027283004/ > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > ---You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout.
-- erik -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
