https://codereview.chromium.org/1027283004/diff/60001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/1027283004/diff/60001/src/bootstrapper.cc#newcode301
src/bootstrapper.cc:301: Handle<Map>
plain_function_map_writable_prototype_;
Can you rename these. Right now it is not clear how there can be
anything but sloppy and strict.
The concept of "plain" function is something new here. It is never
defined what it means.
https://codereview.chromium.org/1027283004/diff/60001/src/bootstrapper.cc#newcode415
src/bootstrapper.cc:415: if (add_restricted_props) { // Add caller.
Maybe
if (add_restricted_props) {
{
...
}
{
...
}
to remove a branch.
https://codereview.chromium.org/1027283004/diff/60001/test/mjsunit/es6/generators-poisoned-properties.js
File test/mjsunit/es6/generators-poisoned-properties.js (right):
https://codereview.chromium.org/1027283004/diff/60001/test/mjsunit/es6/generators-poisoned-properties.js#newcode7
test/mjsunit/es6/generators-poisoned-properties.js:7:
assertEquals(false, (function*() {}).hasOwnProperty("arguments"));
assertFalse
https://codereview.chromium.org/1027283004/diff/60001/test/mjsunit/es6/generators-runtime.js
File test/mjsunit/es6/generators-runtime.js (right):
https://codereview.chromium.org/1027283004/diff/60001/test/mjsunit/es6/generators-runtime.js#newcode50
test/mjsunit/es6/generators-runtime.js:50: var f_own_property_names =
removePoisoned(Object.getOwnPropertyNames(f));
Would this test be cleaner if f was strict?
https://codereview.chromium.org/1027283004/diff/60001/test/mjsunit/harmony/classes.js
File test/mjsunit/harmony/classes.js (right):
https://codereview.chromium.org/1027283004/diff/60001/test/mjsunit/harmony/classes.js#newcode903
test/mjsunit/harmony/classes.js:903: }
Maybe have a derived class too?
https://codereview.chromium.org/1027283004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
