lgtm with nits. Hannes should still have a look.
https://codereview.chromium.org/1026113004/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1026113004/diff/20001/src/objects.cc#newcode8285
src/objects.cc:8285: length = array->Length();
Would it make sense to here (and in the other Add method, too) that the
new length is smaller than the original one?
https://codereview.chromium.org/1026113004/diff/20001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/1026113004/diff/20001/src/objects.h#newcode2636
src/objects.h:2636: // Use this if GC can delete elements from array.
nit: ... from the array.
https://codereview.chromium.org/1026113004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
