https://codereview.chromium.org/1026113004/diff/60001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1026113004/diff/60001/src/objects.cc#newcode8299
src/objects.cc:8299: length = array->Length();
Missing DCHECK from the single-argument version.
Did you try just doing this unconditionally, and was it too slow? It
looks a bit like a trap for the unwary now.
https://codereview.chromium.org/1026113004/diff/60001/src/objects.cc#newcode8309
src/objects.cc:8309: int capacity = array->length();
// This is the length of the FixedArray
https://codereview.chromium.org/1026113004/diff/60001/src/objects.cc#newcode8313
src/objects.cc:8313: capacity = capacity + Max(capacity / 2, 2);
Division by 2 of a signed value can be an expensive operation. Consider
either making it unsigned or using shift.
https://codereview.chromium.org/1026113004/diff/60001/src/objects.cc#newcode8315
src/objects.cc:8315: if (empty) array->SetLength(0);
// This sets the length of the ArrayList, using the first entry in the
fixed array
https://codereview.chromium.org/1026113004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
