dslomov, could you have another look?
This should be less strawmanny now. Changes:
- added cctests
- fixed the global object lookup and looking up lexical things (ScriptTable)
- made the error message refer to the var name & location of the reference
- fixed a bug: we need to check whether the *reference* (VariableProxy) is
inside strong mode, not whether the script scope (where the DYNAMIC_GLOBAL
is)
is strong
https://codereview.chromium.org/1005063002/diff/80001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/1005063002/diff/80001/src/api.cc#newcode1500
src/api.cc:1500: Maybe<bool> has = i::JSReceiver::HasOwnProperty(global,
name);
On 2015/03/24 10:16:24, Dmitry Lomov (chromium) wrote:
Why only own properties?
Also use ScriptCongtextTable for lexicals as well
Done.
https://codereview.chromium.org/1005063002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
