lgtm % comments
https://codereview.chromium.org/1005063002/diff/200001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/1005063002/diff/200001/src/api.cc#newcode1503
src/api.cc:1503: i::ScriptContextTable::LookupResult result;
Maybe change order of lookup: lexicals trump global object, so check
them first. Does not matter atm.
https://codereview.chromium.org/1005063002/diff/200001/src/scopeinfo.cc
File src/scopeinfo.cc (right):
https://codereview.chromium.org/1005063002/diff/200001/src/scopeinfo.cc#newcode132
src/scopeinfo.cc:132: if (Smi::IsValid(start_position)) {
Factory::NewNumberFromInt does this.
https://codereview.chromium.org/1005063002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
