LGTM, but it appears that the Release v8_shell-arm build is broken.
http://codereview.chromium.org/440016/diff/1/2 File tools/v8.xcodeproj/project.pbxproj (right): http://codereview.chromium.org/440016/diff/1/2#newcode1241 tools/v8.xcodeproj/project.pbxproj:1241: 9FBE03E210BD40EA00F8BFBA /* fast-codegen-ia32.cc in Sources */, We used to keep this list sorted as it reduces the potential for conflicts. But we do not modify the Xcode project often enough for that to really matter. http://codereview.chromium.org/440016/diff/1/2#newcode1350 tools/v8.xcodeproj/project.pbxproj:1350: 9FBE03E510BD412600F8BFBA /* fast-codegen-arm.cc in Sources */, ditto http://codereview.chromium.org/440016 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
