>> LGTM, but it appears that the Release v8_shell-arm build is broken. >>
Guys, it appears that Ivan has found a problem (initially I missed the word 'Release' and tried only Debug build). In fast-codegen-arm 'Debug::kARMJSReturnSequenceLength' is being accessed. But it only exists when ENABLE_DEBUGGER_SUPPORT is defined. I could wrap this code in #ifdefs myself, but I'm not sure about what this code does, so I can't set #ifdef boundaries for sure. Can anyone of you address this problem? On Thu, Nov 26, 2009 at 13:24, Mikhail Naganov <[email protected]> wrote: > Inline > > On Wed, Nov 25, 2009 at 22:21, <[email protected]> wrote: >> LGTM, but it appears that the Release v8_shell-arm build is broken. >> > > For me, building v8_shell-arm works. I added 'fast-codegen-ia32' into > 'v8' target, and 'fast-codegen-arm' into 'v8-arm' target. > >> >> http://codereview.chromium.org/440016/diff/1/2 >> File tools/v8.xcodeproj/project.pbxproj (right): >> >> http://codereview.chromium.org/440016/diff/1/2#newcode1241 >> tools/v8.xcodeproj/project.pbxproj:1241: 9FBE03E210BD40EA00F8BFBA /* >> fast-codegen-ia32.cc in Sources */, >> We used to keep this list sorted as it reduces the potential for >> conflicts. But we do not modify the Xcode project often enough for that >> to really matter. >> > > Is order here maintained by hand-editing the project file? In Xcode, I > dragged those files to be in sorted order in 'src/C++' 'folder'. > >> http://codereview.chromium.org/440016/diff/1/2#newcode1350 >> tools/v8.xcodeproj/project.pbxproj:1350: 9FBE03E510BD412600F8BFBA /* >> fast-codegen-arm.cc in Sources */, >> ditto >> >> http://codereview.chromium.org/440016 >> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
