http://codereview.chromium.org/405033/diff/3004/5001 File src/arm/fast-codegen-arm.cc (right):
http://codereview.chromium.org/405033/diff/3004/5001#newcode253 src/arm/fast-codegen-arm.cc:253: Register scratch) { The problem is that I want the same signature across all three architectures, and IA32 doesn't have a default scratch register. (And I want the same signature, because I want it to be a method of FastCodeGenerator, so that it has access to function_, otherwise I would have to pass that as a parameter instead). Also, I don't want to guarantee that the MacroAssembler function LoadContext doesn't use ip for something else. http://codereview.chromium.org/405033/diff/3004/5001#newcode581 src/arm/fast-codegen-arm.cc:581: Move(Expression::kValue, object_slot, r0); That would make sense. It's more obvious what happens, and the code will probably be slightly shorter. I'll do this. http://codereview.chromium.org/405033 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
