Drive by comments, questions, and suggestions.
http://codereview.chromium.org/405033/diff/3005/5018 File src/ia32/fast-codegen-ia32.cc (right): http://codereview.chromium.org/405033/diff/3005/5018#newcode98 src/ia32/fast-codegen-ia32.cc:98: __ mov(Operand(esi, Context::SlotOffset(slot->index())), eax); Why can we avoid the write barrier here? http://codereview.chromium.org/405033/diff/3005/5018#newcode123 src/ia32/fast-codegen-ia32.cc:123: __ mov(ecx, eax); // Duplicate result. This seems like more generality (and complication) than we need. As far as I can see, 'arguments' is in the stack or we don't need to set it anyway (it's shadowed) [*]. '.arguments' may be in the stack or the local context. In either case, we shouldn't need to duplicate the result. [*] We would thus break from our existing arguments-shadowing behavior, to match the spec (and ES5). That seems desirable. http://codereview.chromium.org/405033 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
