Thank you for the patch. Before we can add this code to the repository you need to sign the Google Individual Contributor License Agreement<http://code.google.com/legal/individual-cla-v1.0.html>, see http://code.google.com/p/v8/wiki/Contributing for more details.
Regards, Søren On Thu, Nov 26, 2009 at 12:37, <[email protected]> wrote: > LGTM > > Please change the svn:eol-style to native. > > > > http://codereview.chromium.org/431047/diff/1/4 > File src/platform-openbsd.cc (right): > > http://codereview.chromium.org/431047/diff/1/4#newcode142 > src/platform-openbsd.cc:142: // TODO(1240712): munmap has a return value > which is ignored here. > Please remove this TODO or create a new bug in > http://code.google.com/p/v8/issues/list and change the TODO to refer to > this new bug. > > > http://codereview.chromium.org/431047 > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
