http://codereview.chromium.org/431047/diff/1/4 File src/platform-openbsd.cc (right):
http://codereview.chromium.org/431047/diff/1/4#newcode142 src/platform-openbsd.cc:142: // TODO(1240712): munmap has a return value which is ignored here. On 2009/11/26 11:37:38, Søren Gjesse wrote: > Please remove this TODO or create a new bug in > http://code.google.com/p/v8/issues/list and change the TODO to refer to this new > bug. Fixed (there's an ASSERT that it returns 0 which is success, that should be sufficient as there's nothing else that can be really done if it fails, it's a void free function) http://codereview.chromium.org/431047/diff/1/4#newcode269 src/platform-openbsd.cc:269: /* On 2009/11/25 21:06:54, Erik Corry wrote: > Please don't leave commented code in the source. Done. http://codereview.chromium.org/431047/diff/1/4#newcode557 src/platform-openbsd.cc:557: if (active_sampler_->IsProfiling()) { On 2009/11/25 21:06:54, Erik Corry wrote: > And here Done. http://codereview.chromium.org/431047 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
