Reviewers: Michael Starzinger,
Message:
Could you take a look, please?
There was a CF test for this, but it seemed too brittle to be included here.
Description:
[turbofan] Weaken a DCHECK to allow tagged numbers as double constants in
frame
states.
BUG=chromium:472078
LOG=n
[email protected]
Please review this at https://codereview.chromium.org/1047173002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -1 lines):
M src/compiler/code-generator.cc
Index: src/compiler/code-generator.cc
diff --git a/src/compiler/code-generator.cc b/src/compiler/code-generator.cc
index
47dce3105cf708fd2778c0f9585446c98ac31637..b83db1a1a1540b34a9c50d033a183049a4594a53
100644
--- a/src/compiler/code-generator.cc
+++ b/src/compiler/code-generator.cc
@@ -557,7 +557,8 @@ void
CodeGenerator::AddTranslationForOperand(Translation* translation,
break;
case Constant::kFloat64:
DCHECK(type == kMachFloat64 || type == kMachAnyTagged ||
- type == kRepTagged || type == (kTypeInt32 | kRepTagged) ||
+ type == kRepTagged || type == (kTypeNumber | kRepTagged) ||
+ type == (kTypeInt32 | kRepTagged) ||
type == (kTypeUint32 | kRepTagged));
constant_object =
isolate()->factory()->NewNumber(constant.ToFloat64());
break;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
