Cool that you're unifying variable declaration parsing in Parser &
PreParser,
it's one of my pet peeves that they are inconsistent!
https://codereview.chromium.org/1062263002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/1062263002/diff/1/test/cctest/test-parsing.cc#newcode4644
test/cctest/test-parsing.cc:4644: RunParserSyncTest(context_data, data,
kError, nullptr, 0, nullptr, 0);
You don't need the params after kError.
https://codereview.chromium.org/1062263002/diff/1/test/cctest/test-parsing.cc#newcode4691
test/cctest/test-parsing.cc:4691:
Hmm, none of the added tests exercises the code path for the ndecl != 1
error? Could you add some?
https://codereview.chromium.org/1062263002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
