lgtm whenever arv is happy
https://codereview.chromium.org/1062263002/diff/80001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1062263002/diff/80001/src/parser.cc#newcode3382
src/parser.cc:3382: bool accept_IN = num_decl >= 1;
I was reading this code for a while and it's slightly messy that we
first check for >= 1 and almost right after, check for != 1 - but I
guess this is necessary to produce the right kinds of errors. E.g., if
there's no "in" or "of" keyword, we want to whine about that, not about
multiple declarations, I guess. So I don't have any concrete ideas on
how to make this better.
https://codereview.chromium.org/1062263002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
