thanks for the review, will land this tonight
https://codereview.chromium.org/938443002/diff/450001/src/compiler/ast-loop-assignment-analyzer.cc
File src/compiler/ast-loop-assignment-analyzer.cc (right):
https://codereview.chromium.org/938443002/diff/450001/src/compiler/ast-loop-assignment-analyzer.cc#newcode198
src/compiler/ast-loop-assignment-analyzer.cc:198: void
ALAA::VisitSpread(Spread* e) { Visit(e->expression()); }
On 2015/04/08 18:58:59, arv wrote:
On 2015/04/08 18:48:26, Michael Starzinger wrote:
> nit: Should be UNREACHABLE as well, correct?
I don't think so. The spread expression can be anything.
Spread* nodes get completely removed from the graph, so it could just as
well be UNREACHABLE. I don't think it matters much though, since it will
hit the other ones if this line is reached
https://codereview.chromium.org/938443002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
