looks good, go ahead with platform ports!
https://codereview.chromium.org/938443002/diff/380002/src/flag-definitions.h
File src/flag-definitions.h (left):
https://codereview.chromium.org/938443002/diff/380002/src/flag-definitions.h#oldcode237
src/flag-definitions.h:237:
nit: restore this empty line
https://codereview.chromium.org/938443002/diff/380002/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/938443002/diff/380002/src/flag-definitions.h#newcode184
src/flag-definitions.h:184:
nit: stray empty line
https://codereview.chromium.org/938443002/diff/380002/src/harmony-spread.js
File src/harmony-spread.js (right):
https://codereview.chromium.org/938443002/diff/380002/src/harmony-spread.js#newcode14
src/harmony-spread.js:14: if (SpreadArguments) return;
Why this 'if' is needed?
https://codereview.chromium.org/938443002/diff/380002/src/harmony-spread.js#newcode16
src/harmony-spread.js:16: SpreadArguments = function spreadArguments() {
These functions will be eagerly compiled at snapshot-building time. To
avoid this, please move them outside the SetupSpreadHelper.
https://codereview.chromium.org/938443002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
