Looks good! I just have a request to use kShallowProperties in one more
place.
https://codereview.chromium.org/1097963002/diff/80001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/1097963002/diff/80001/src/ast.h#newcode1511
src/ast.h:1511: flags |= kShallowProperties;
Could you also push this flag into
FullCodeGenerator::MustCreateObjectLiteralWithRuntime()?
(in src/full-codegen.cc)
There are three tests that can be eliminated with a look at this nice
new kShallowProperties flag.
https://codereview.chromium.org/1097963002/diff/80001/src/compiler/js-intrinsic-lowering.cc
File src/compiler/js-intrinsic-lowering.cc (right):
https://codereview.chromium.org/1097963002/diff/80001/src/compiler/js-intrinsic-lowering.cc#newcode122
src/compiler/js-intrinsic-lowering.cc:122: node->RemoveInput(4);
nit: a comment would be nice on the RemoveInput...what's being removed?
https://codereview.chromium.org/1097963002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
