lgtm
https://codereview.chromium.org/1097963002/diff/100001/src/compiler/js-intrinsic-lowering.cc
File src/compiler/js-intrinsic-lowering.cc (right):
https://codereview.chromium.org/1097963002/diff/100001/src/compiler/js-intrinsic-lowering.cc#newcode134
src/compiler/js-intrinsic-lowering.cc:134: int length =
mconst.Value().handle()->length() / 2;
Can we have a comment that this thing takes an array of pairs (and thus
the /2)?
https://codereview.chromium.org/1097963002/diff/100001/src/full-codegen.cc
File src/full-codegen.cc (right):
https://codereview.chromium.org/1097963002/diff/100001/src/full-codegen.cc#newcode427
src/full-codegen.cc:427: expr->ComputeFlags() !=
ObjectLiteral::kShallowProperties ||
Is ComputeFlags() expensive enough to need a cache?
https://codereview.chromium.org/1097963002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
