LGTM with nits.
https://codereview.chromium.org/1092043002/diff/60001/src/isolate.h
File src/isolate.h (right):
https://codereview.chromium.org/1092043002/diff/60001/src/isolate.h#newcode1023
src/isolate.h:1023: void
MaintainArrayProtectorOnSetElement(Handle<JSObject> object);
naming nit: "Maintain" doesn't sound like something is about to change.
How about "Update" or "Invalidate"?
https://codereview.chromium.org/1092043002/diff/60001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1092043002/diff/60001/src/objects.cc#newcode17108
src/objects.cc:17108: auto isolate = cell->GetIsolate();
nit: s/auto/Isolate*/ please?
https://codereview.chromium.org/1092043002/diff/60001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/1092043002/diff/60001/test/cctest/test-api.cc#newcode16645
test/cctest/test-api.cc:16645: printf("script: %s\n", script);
nit: debugging leftover?
https://codereview.chromium.org/1092043002/diff/60001/test/cctest/test-api.cc#newcode16661
test/cctest/test-api.cc:16661: DCHECK_EQ(true,
i_isolate->IsFastArrayConstructorPrototypeChainIntact());
s/DCHECK/CHECK/, and again below?
https://codereview.chromium.org/1092043002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
