Thanks Jakob, addressed issues.
And, a release mode test failure caused me to add a TODO and --nostress-opt
on a
test.
The test expects to deploy the NaN-as-hole optimization, repeatedly, once
per
stress run. But since we don't create a new isolate it isn't possible
anymore.
That is, future runs will cause compilation that is safer, and avoids the
optimization because the protector cell was polluted.
The TODO is to maybe provide a runtime function for manually reset of this
cell,
if it's important enough. But since only one test hits the issue it may not
be
yet.
--Michael
https://codereview.chromium.org/1092043002/diff/60001/src/isolate.h
File src/isolate.h (right):
https://codereview.chromium.org/1092043002/diff/60001/src/isolate.h#newcode1023
src/isolate.h:1023: void
MaintainArrayProtectorOnSetElement(Handle<JSObject> object);
On 2015/04/21 15:41:49, Jakob wrote:
naming nit: "Maintain" doesn't sound like something is about to
change. How
about "Update" or "Invalidate"?
Good idea, I'll go with Update.
https://codereview.chromium.org/1092043002/diff/60001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1092043002/diff/60001/src/objects.cc#newcode17108
src/objects.cc:17108: auto isolate = cell->GetIsolate();
On 2015/04/21 15:41:49, Jakob wrote:
nit: s/auto/Isolate*/ please?
Done.
https://codereview.chromium.org/1092043002/diff/60001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/1092043002/diff/60001/test/cctest/test-api.cc#newcode16645
test/cctest/test-api.cc:16645: printf("script: %s\n", script);
On 2015/04/21 15:41:49, Jakob wrote:
nit: debugging leftover?
Done.
https://codereview.chromium.org/1092043002/diff/60001/test/cctest/test-api.cc#newcode16661
test/cctest/test-api.cc:16661: DCHECK_EQ(true,
i_isolate->IsFastArrayConstructorPrototypeChainIntact());
On 2015/04/21 15:41:49, Jakob wrote:
s/DCHECK/CHECK/, and again below?
Done.
https://codereview.chromium.org/1092043002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
