lgtm, with one nit.
https://codereview.chromium.org/1100083002/diff/100001/src/mips64/lithium-codegen-mips64.cc
File src/mips64/lithium-codegen-mips64.cc (right):
https://codereview.chromium.org/1100083002/diff/100001/src/mips64/lithium-codegen-mips64.cc#newcode3345
src/mips64/lithium-codegen-mips64.cc:3345: __ lw(scratch,
FieldMemOperand(result, Cell::kValueOffset));
nit: This should probably be 'ld'. I say 'probably' since in general
values are 64-bit. But you are using just a bit flag here, so it's fine
(as long as we never go to big-endian mips64, which we have no plans for
:)
It might be worth a comment here that you are using just LS bit(s) of
value.
https://codereview.chromium.org/1100083002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
