On 2015/04/23 13:40:00, Jakob wrote:
LGTM with a bunch of comments, mostly nits though. Happy to take another
look
if
you want.
MIPS folks, can you please take a look at the lithium-codegen-mips*
changes?
In src/mips64/lithium-codegen-mips64.cc, line 3345
__ lw(scratch, FieldMemOperand(result, Cell::kValueOffset)); very likely
should
be
__ ld(scratch, FieldMemOperand(result, Cell::kValueOffset));
I will test it.
Also I guess at line #3359 of src/arm/lithium-codegen-arm.cc
__ LoadRoot(scratch, Heap::kArrayProtectorRootIndex); should be
__ LoadRoot(result, Heap::kArrayProtectorRootIndex);
And in both of the matching MIPS files too.
https://codereview.chromium.org/1100083002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
