Sorry for the delay - please use my @chromium.org address (I should get the @gmail.com one removed).
I am not sure what happens here when the wait for debugger connection flag is set. Isn't V8 execution supposed to wait until a debugger comes along and processes the first debugger message? Should the debug break flag be raised to ensure that a break will happen as soon as any code is executed? You will need to provide some test which uses and tests this new flag. There are some tests covering the DebugAgent, but they probably needs to be extended. Please don't add the AsyncDebugRunner until it is actually used, and I still think we should stick the the function approach used by the rest of the API. http://codereview.chromium.org/481005/diff/2001/2002 File include/v8-debug.h (right): http://codereview.chromium.org/481005/diff/2001/2002#newcode85 include/v8-debug.h:85: * pending. This comment does not say anything about what you will achieve by implementing a class inheriting from this. http://codereview.chromium.org/481005/diff/2001/2002#newcode87 include/v8-debug.h:87: class AsyncDebugRunner { Don't add this until you are actually using it. http://codereview.chromium.org/481005/diff/2001/2002#newcode282 include/v8-debug.h:282: static bool EnableAgent(const char* name, int port, bool wait_for_connection, We should add default values for new parameters to avoid breaking existing clients. http://codereview.chromium.org/481005 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
