http://codereview.chromium.org/481005/diff/2001/2002 File include/v8-debug.h (right):
http://codereview.chromium.org/481005/diff/2001/2002#newcode85 include/v8-debug.h:85: * pending. On 2009/12/10 14:58:11, Søren Gjesse wrote: > This comment does not say anything about what you will achieve by implementing a > class inheriting from this. I added a sentence about this. http://codereview.chromium.org/481005/diff/2001/2002#newcode87 include/v8-debug.h:87: class AsyncDebugRunner { On 2009/12/10 14:58:11, Søren Gjesse wrote: > Don't add this until you are actually using it. I'm ready to use it from sample program "lineprocessor". http://codereview.chromium.org/481005/diff/2001/2002#newcode282 include/v8-debug.h:282: static bool EnableAgent(const char* name, int port, bool wait_for_connection, On 2009/12/10 14:58:11, Søren Gjesse wrote: > We should add default values for new parameters to avoid breaking existing > clients. Done. http://codereview.chromium.org/481005 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
