Maybe change the name of this to jsdebugging or something like that. You should also add the sample to the SConstruct file to make it buildbable, and maybe also a Visual Studio project file (I can do that afterwards).
http://codereview.chromium.org/491006/diff/3001/3002 File samples/lineprocessor.cc (right): http://codereview.chromium.org/491006/diff/3001/3002#newcode43 samples/lineprocessor.cc:43: * When program starts, script gets compiled and run. To this point should I don't see why this sample should require any specific function to be declared. How about just run the scripts. You can then define callback functions for feof and fgets (call them something else though) and then have the suggested JavaScript code have a top-level loop doing the RunCycle work. http://codereview.chromium.org/491006/diff/3001/3002#newcode63 samples/lineprocessor.cc:63: * allows remote debugger to attach and debug custom JavaScript code. Maybe delete "custom" http://codereview.chromium.org/491006/diff/3001/3002#newcode66 samples/lineprocessor.cc:66: * 1. Wait for remote debugger to attach With the forced break in wait for connection the "debugger" statement is no longer needed. http://codereview.chromium.org/491006/diff/3001/3002#newcode115 samples/lineprocessor.cc:115: // TODO(peter.rybin): implement this. Please open a bug on this and change to TODO(bugnumber). http://codereview.chromium.org/491006/diff/3001/3002#newcode119 samples/lineprocessor.cc:119: // TODO(peter.rybin): implement this. TODO(bugnumber) here as well. http://codereview.chromium.org/491006/diff/3001/3002#newcode170 samples/lineprocessor.cc:170: // Run script. As a result the script should declare "ProcessLine" function I don't think this sample needs to require specific code in the JavaScript files processed. http://codereview.chromium.org/491006/diff/3001/3002#newcode200 samples/lineprocessor.cc:200: bool RunCycle(v8::Handle<v8::Function> process_fun, bool report_exceptions) { Remove empty line? http://codereview.chromium.org/491006/diff/3001/3002#newcode221 samples/lineprocessor.cc:221: v8::Handle<v8::String> input_line = v8::String::New(buffer); Remove {}'s? http://codereview.chromium.org/491006 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
