http://codereview.chromium.org/491006/diff/9001/9003 File samples/lineprocessor.cc (right):
http://codereview.chromium.org/491006/diff/9001/9003#newcode41 samples/lineprocessor.cc:41: * script. The script is specified in command line parameters. On 2010/01/18 11:10:22, Søren Gjesse wrote:
in -> with/by?
Done. http://codereview.chromium.org/491006/diff/9001/9003#newcode43 samples/lineprocessor.cc:43: * Main cycle of the program should sequentially read lines from standard input On 2010/01/18 11:10:22, Søren Gjesse wrote:
Main cycle -> The main cycle
should -> will
Done. http://codereview.chromium.org/491006/diff/9001/9003#newcode44 samples/lineprocessor.cc:44: * and processes them and print to standard output until input closes. On 2010/01/18 11:10:22, Søren Gjesse wrote:
and processes -> , process
Done. http://codereview.chromium.org/491006/diff/9001/9003#newcode47 samples/lineprocessor.cc:47: * 1. Main cycle is on C++ side. Program should be run with --main-cycle-in-cpp On 2010/01/18 11:10:22, Søren Gjesse wrote:
Main cycle -> The main cycle
Done. http://codereview.chromium.org/491006/diff/9001/9003#newcode48 samples/lineprocessor.cc:48: * option. Script must declare function named "ProcessLine". Main cycle in C++ On 2010/01/18 11:10:22, Søren Gjesse wrote:
declare function -> declare a function
Main cycle -> The main cycle
Done. http://codereview.chromium.org/491006/diff/9001/9003#newcode49 samples/lineprocessor.cc:49: * reads line and calls this function for processing every time. On 2010/01/18 11:10:22, Søren Gjesse wrote:
reads line -> read lines
Done. http://codereview.chromium.org/491006/diff/9001/9003#newcode57 samples/lineprocessor.cc:57: * 2. Main cycle is on JavaScript side. Program should be run with On 2010/01/18 11:10:22, Søren Gjesse wrote:
Main cycle -> The main cycle
on JavaScript side -> in JavaScript
Done. http://codereview.chromium.org/491006/diff/9001/9003#newcode397 samples/lineprocessor.cc:397: // The callback that is invoked by v8 whenever the JavaScript 'print' On 2010/01/18 11:10:22, Søren Gjesse wrote:
Please change this comment to describe ReadLine.
Done. http://codereview.chromium.org/491006
-- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
