lgtm with a bunch of nits
https://codereview.chromium.org/1102523003/diff/140001/src/preparser.cc
File src/preparser.cc (right):
https://codereview.chromium.org/1102523003/diff/140001/src/preparser.cc#newcode261
src/preparser.cc:261: if (maybe_reset && (!starts_with_identifier ||
++count_statements > 200)) {
can we define 200 has a const?
https://codereview.chromium.org/1102523003/diff/140001/src/scanner-character-streams.cc
File src/scanner-character-streams.cc (right):
https://codereview.chromium.org/1102523003/diff/140001/src/scanner-character-streams.cc#newcode149
src/scanner-character-streams.cc:149: pos_ = bookmark_;
why no DCHECK here?
https://codereview.chromium.org/1102523003/diff/140001/src/scanner.h
File src/scanner.h (right):
https://codereview.chromium.org/1102523003/diff/140001/src/scanner.h#newcode374
src/scanner.h:374: };
disallow copy/assign
https://codereview.chromium.org/1102523003/diff/140001/src/scanner.h#newcode758
src/scanner.h:758: // - bookmark_c0_ == -1: No bookmark has been set.
how about defining an enum for -1 and -2?
https://codereview.chromium.org/1102523003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
