On 2015/04/30 07:07:59, jochen wrote:
On 2015/04/29 at 18:27:22, binji wrote:
> https://codereview.chromium.org/1069883002/diff/220001/src/accessors.cc
> File src/accessors.cc (right):
>
>
https://codereview.chromium.org/1069883002/diff/220001/src/accessors.cc#newcode103
> src/accessors.cc:103: case JS_SHARED_TYPED_ARRAY_TYPE:
> On 2015/04/28 18:31:46, jochen wrote:
> > can shared array buffers be neutered?
>
> no, does that affect the code here?
JSArrayBufferViewFieldAccessors include a check whether the underlying
ArrayBuffer is neutered. Also, they blindly assume that the types all
derive
from JSArrayBufferView.
And so do the elements() accesses in hydrogen.cc
This should be OK, I think. SharedArrayBuffer and SharedTypedArrays use
JSArrayBuffer/JSArrayBufferView/JSTypedArray under the hood.
It's unfortunate that SAB don't support neutering while the JSArrayBuffers
do,
but duplicating the JSArrayBuffer code would be worse IMO. As long as the
external API blocks all attempts to neuter it should be fine, right? As far
as
JSArrayBufferViewFieldAccessors is concerned, it will check whether a SAB is
neutered, but it will never be true.
https://codereview.chromium.org/1069883002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
