https://codereview.chromium.org/1069883002/diff/220001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/1069883002/diff/220001/src/bootstrapper.cc#newcode1377
src/bootstrapper.cc:1377: is_shared ? JS_SHARED_TYPED_ARRAY_TYPE :
JS_TYPED_ARRAY_TYPE;
change to (is_shared == SHARED) ? ...
https://codereview.chromium.org/1069883002/diff/220001/src/runtime/runtime-typedarray.cc
File src/runtime/runtime-typedarray.cc (right):
https://codereview.chromium.org/1069883002/diff/220001/src/runtime/runtime-typedarray.cc#newcode79
src/runtime/runtime-typedarray.cc:79: bool is_shared =
array_buffer->is_shared();
This should be array_buffer->is_shared() == SHARED. Or just make
JSArrayBuffer::is_shared return bool, the main motivation for the
SharedFlag is to make the sharing explicit when passed as a parameter.
(That said, I am a bit surprised that C++ is happy about using enum as
bool.)
https://codereview.chromium.org/1069883002/diff/220001/src/runtime/runtime-typedarray.cc#newcode201
src/runtime/runtime-typedarray.cc:201:
DCHECK(!array_buffer->is_shared());
On 2015/04/28 18:31:46, jochen wrote:
why? What about ArrayBuffer.transfer?
The whole idea of SharedArrayBuffer is that it can be shared, i.e., not
neutered on transfer.
https://codereview.chromium.org/1069883002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
