LGTM, but it would be good to get Kevin's input about all the jump target interaction.
-Ivan http://codereview.chromium.org/507040/diff/1/2 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/507040/diff/1/2#newcode1869 src/ia32/codegen-ia32.cc:1869: bool is_for_loop_compare = node->AsCompareOperation() Shouldn't you do a " != NULL" here? http://codereview.chromium.org/507040/diff/1/2#newcode1874 src/ia32/codegen-ia32.cc:1874: // The right side value is either a smi or heap number. Comment does not match the check. Right side is a smi. http://codereview.chromium.org/507040/diff/1/2#newcode1888 src/ia32/codegen-ia32.cc:1888: __ cvtsi2sd(xmm0, Operand(temp.reg())); Why do you keep converting the value to double from int on every check? You could just create the double immediate and load it directly. http://codereview.chromium.org/507040/diff/1/2#newcode6849 src/ia32/codegen-ia32.cc:6849: // The calling convention with registers is left in edx and right in eax. Unmotivated space? http://codereview.chromium.org/507040/diff/1/6 File src/ia32/disasm-ia32.cc (right): http://codereview.chromium.org/507040/diff/1/6#newcode1052 src/ia32/disasm-ia32.cc:1052: } if(*data == 0x57) { missing else? http://codereview.chromium.org/507040 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
