//Lars
http://codereview.chromium.org/507040/diff/1/2 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/507040/diff/1/2#newcode1869 src/ia32/codegen-ia32.cc:1869: bool is_for_loop_compare = node->AsCompareOperation() On 2009/12/17 21:03:50, iposva wrote: > Shouldn't you do a " != NULL" here? Done. http://codereview.chromium.org/507040/diff/1/2#newcode1874 src/ia32/codegen-ia32.cc:1874: // The right side value is either a smi or heap number. On 2009/12/17 21:03:50, iposva wrote: > Comment does not match the check. Right side is a smi. Done. http://codereview.chromium.org/507040/diff/1/2#newcode1888 src/ia32/codegen-ia32.cc:1888: __ cvtsi2sd(xmm0, Operand(temp.reg())); I'm not sure it makes a difference. I'll try the optimization after the commit. On 2009/12/17 21:03:50, iposva wrote: > Why do you keep converting the value to double from int on every check? You > could just create the double immediate and load it directly. http://codereview.chromium.org/507040/diff/1/2#newcode6849 src/ia32/codegen-ia32.cc:6849: // The calling convention with registers is left in edx and right in eax. On 2009/12/17 21:03:50, iposva wrote: > Unmotivated space? Done. http://codereview.chromium.org/507040/diff/1/6 File src/ia32/disasm-ia32.cc (right): http://codereview.chromium.org/507040/diff/1/6#newcode1052 src/ia32/disasm-ia32.cc:1052: } if(*data == 0x57) { On 2009/12/17 21:03:50, iposva wrote: > missing else? Done. http://codereview.chromium.org/507040 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
